207 rollup compaction simplified #232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main-1.0.0 #232 +/- ##
==============================================
- Coverage 92.00% 90.86% -1.15%
==============================================
Files 88 93 +5
Lines 2214 2386 +172
Branches 168 178 +10
==============================================
+ Hits 2037 2168 +131
- Misses 177 218 +41 ☔ View full report in Codecov by Sentry. |
cugni
approved these changes
Nov 23, 2023
src/test/scala/io/qbeast/spark/utils/QbeastFilterPushdownTest.scala
Outdated
Show resolved
Hide resolved
|
We are finally merging the rollup!! Great job!! @alexeiakimov |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The present PR provides initial implementation for indexing and optimization based on the rollup compaction as it is proposed in the #207. The most important changes are
AddFilehas changed to support multiple blocks.replicatedflags of its blocks and id not persisted in the DeltaLog metadata anymore.Type of change
This PR introduces incompatible changes in the metadata format for both individual index files and for the DeltaLog as well. The tables written with the previous version cannot be read by the present version, and vice versa. However the existing tables can be converted (int theory) to the new format by transforming the AddFile tags and DeltaLog metadata without touching the actual files.
How Has This Been Tested? (Optional)
The correctness tests are provided in the project code. Also @Jiaweihu08 did some extra performance test comparing the proposed version with the previous one and pure Delta.